[Intel GPU] Enable optim SR test #3055
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3055
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit b1121ac with merge base f92b898 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
test/test_low_bit_optim.py
Outdated
| torch.testing.assert_close(p2, p1) | ||
|
|
||
| @parametrize("device", _DEVICES) | ||
| def test_optim_bf16_stochastic_round_correctness(self): |
There was a problem hiding this comment.
device arg is not added to the function
There was a problem hiding this comment.
@arlesniak _DEVICES is the global variable in this file, I don't think your change is needed.
There was a problem hiding this comment.
The "test_optim_bf16_stochastic_round_correctness" should be parametrized with _DEVICES global variable, which contains other devices (XPU if detected). Without the PR changes the choice was cuda, cpu only.
There was a problem hiding this comment.
Are you sure? According to this code,https://github.com/pytorch/ao/blob/main/torchao/utils.py#L143 when the xpu is available in your ENV, the _DEVICES will contain the XPU.
There was a problem hiding this comment.
Let me be more precise. You're right, the _DEVICES list will contain XPU if detected. Without the PR changes the test will be triggered once with the hardcoded device choice - cuda or cpu: https://github.com/pytorch/ao/blob/main/test/test_low_bit_optim.py#L423, regardless of _DEVICES content.
After the PR changes, the test will be triggered separately for every device from the _DEVICES including XPU (similiar to some other parametrized tests i.e. test_quantize_8bit_with_qmap_correctness etc).
arlesniak
force-pushed
the
arlesniak/enable_optim_sr_test_xpu
branch
from
cfd22f6 to
b1121ac
Compare
liangan1
added
topic: improvement
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
4 participants
Enable optim_bf16_stochastic_round_correctness test for XPU